requested/severity metadata + minor style tweaks
@@ -1125,7 +1125,7 @@ def com_google_fonts_check_name_license(ttFont, license):
if value != placeholder:
failed = True
yield FAIL,\
- Message("wrong", \
+ Message("wrong",
f'License file {license} exists but'
f' NameID {NameID.LICENSE_DESCRIPTION}'
f' (LICENSE DESCRIPTION) value on platform'
@@ -1142,7 +1142,7 @@ def com_google_fonts_check_name_license(ttFont, license):
if not entry_found:
yield FAIL,\
- Message("missing", \
+ Message("missing",
f"Font lacks NameID {NameID.LICENSE_DESCRIPTION}"
f" (LICENSE DESCRIPTION). A proper licensing"
f" entry must be set.")
@@ -4330,9 +4330,13 @@ def com_google_fonts_check_repo_fb_report(family_directory):
@check(
id = "com.google/fonts/check/repo/upstream_yaml_has_required_fields",
rationale = """
- If a family has been pushed using the gftools packager, we must check that all the required fields in the upstream.yaml file have been populated
+ If a family has been pushed using the gftools packager, we must check that all the required fields in the upstream.yaml file have been populated.
""",
- conditions = ["upstream_yaml"]
+ conditions = ["upstream_yaml"],
+ misc_metadata = {
+ 'severity': 10,
+ 'request': 'https://github.com/googlefonts/fontbakery/issues/3338'
+ }
)
def com_google_fonts_check_repo_upstream_yaml_has_required_fields(upstream_yaml):
"""Check upstream.yaml file contains all required fields"""
@@ -4341,8 +4345,10 @@ def com_google_fonts_check_repo_upstream_yaml_has_required_fields(upstream_yaml)
missing_fields = required_fields - upstream_fields
if missing_fields:
- yield FAIL, Message('missing-fields',
- f"The upstream.yaml file is missing the following fields: {list(missing_fields)}")
+ yield FAIL,\
+ Message('missing-fields',
+ f"The upstream.yaml file is missing the following fields:"
+ f" {list(missing_fields)}")
else:
yield PASS, "The upstream.yaml file contains all necessary fields"
